Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-1567]: add sweep token in ReserveHelpers #246

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

GitGuru7
Copy link
Contributor

Description

This PR add SweepToken function in the ReserverHelpers. Allow only sweeping the tokens not tracked in assetsReserves, or the surplus (untracked) in these tokens. Send the tokens to the admin/owner of the contract, to avoid potential issues.

Resolves VEN-1567

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this Jun 13, 2023
@Debugger022
Copy link
Collaborator

@GitGuru7 Please resolve the conflicts.

kkirka
kkirka previously approved these changes Jul 19, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 76%
contracts.Lens 95% 65%
contracts.Pool 100% 92%
contracts.Rewards 95% 62%
contracts.RiskFund 99% 72%
contracts.Shortfall 100% 88%
contracts.lib 100% 100%
Summary 97% (1420 / 1471) 75% (422 / 564)

@GitGuru7 GitGuru7 merged commit fb0d1c7 into develop Jul 20, 2023
3 checks passed
@kkirka kkirka deleted the feature/VEN-1567 branch November 29, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants